RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 20:15:00 +00:00
Code Issues Activity Actions

LibWeb: Flesh out prepare_script and execute_script

Browse source 
This fills in a bunch of the FIXMEs that was in prepare_script.

execute_script is almost finished, it's just missing the module side.

As an aside, let's not assert when inserting a script element with
innerHTML.
This commit is contained in:
Luke 2021-01-28 20:31:20 +00:00 • committed by Andreas Kling
parent dbbc378fb2
commit 3f5532d43e
8 changed files with 188 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/Parser/HTMLDocumentParser.cpp
View file

@ -170,6 +170,7 @@ void HTMLDocumentParser::run(const URL& url)
auto scripts_to_execute_when_parsing_has_finished = m_document->take_scripts_to_execute_when_parsing_has_finished({});
for (auto& script : scripts_to_execute_when_parsing_has_finished) {
// FIXME: Spin the event loop until the script is ready to be parser executed and there's no style sheets blocking scripts.
script.execute_script();
}
@ -177,6 +178,8 @@ void HTMLDocumentParser::run(const URL& url)
content_loaded_event->set_bubbles(true);
m_document->dispatch_event(content_loaded_event);
// FIXME: The document parser shouldn't execute these, it should just spin the event loop until the list becomes empty.
// FIXME: Once the set has been added, also spin the event loop until the set becomes empty.
auto scripts_to_execute_as_soon_as_possible = m_document->take_scripts_to_execute_as_soon_as_possible({});
for (auto& script : scripts_to_execute_as_soon_as_possible) {
script.execute_script();
@ -583,7 +586,7 @@ void HTMLDocumentParser::handle_in_head(HTMLToken& token)
script_element.set_non_blocking({}, false);
if (m_parsing_fragment) {
TODO();
script_element.set_already_started({}, true);
}
if (m_invoked_via_document_write) {