From 3f7de2713eda03ed6ee3eaf43d4b789a5b70009b Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 2 Jan 2020 02:39:25 +0100 Subject: [PATCH] Kernel: Make mknod() respect the process umask Otherwise the /bin/mknod command would create world-writable inodes by default (when run by superuser) which you probably don't want. --- Kernel/Process.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp index 39c3f68df2..7d6f76d657 100644 --- a/Kernel/Process.cpp +++ b/Kernel/Process.cpp @@ -3483,7 +3483,7 @@ int Process::sys$mknod(const char* pathname, mode_t mode, dev_t dev) return -EPERM; } - return VFS::the().mknod(StringView(pathname), mode, dev, current_directory()); + return VFS::the().mknod(StringView(pathname), mode & ~umask(), dev, current_directory()); } int Process::sys$dump_backtrace()