RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:27:44 +00:00
Code Issues Activity Actions

LibCore: Call the mkstemp function in a slightly prettier way

Browse source 
This removes a FIXME, although the new version isn't less char-pointery.
This commit is contained in:
Arda Cinar 2023-01-10 17:30:04 +03:00 • committed by Tim Flynn
parent 8ccd6a31dc
commit 3f99a8734e
2 changed files with 12 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibCore/Group.cpp
View file

@ -51,11 +51,11 @@ ErrorOr<void> Group::sync()
auto new_group_file_content = TRY(generate_group_file());
char new_group_name[] = "/etc/group.XXXXXX";
size_t new_group_name_length = strlen(new_group_name);
char new_group_file[] = "/etc/group.XXXXXX";
auto new_group_file_view = StringView { new_group_file, sizeof(new_group_file) };
{
auto new_group_fd = TRY(Core::System::mkstemp({ new_group_name, new_group_name_length }));
auto new_group_fd = TRY(Core::System::mkstemp(new_group_file));
ScopeGuard new_group_fd_guard([new_group_fd] { close(new_group_fd); });
TRY(Core::System::fchmod(new_group_fd, 0664));
@ -63,7 +63,7 @@ ErrorOr<void> Group::sync()
VERIFY(static_cast<size_t>(nwritten) == new_group_file_content.length());
}
TRY(Core::System::rename({ new_group_name, new_group_name_length }, "/etc/group"sv));
TRY(Core::System::rename(new_group_file_view, "/etc/group"sv));
return {};
}