From 3f9e018d9a2f2868b8ad98c0782e40994a145065 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 22 Jul 2021 22:43:06 +0200 Subject: [PATCH] CrashDaemon: Remove BACKTRACE_DEBUG debugging code This thing seems to work fine, no need to hang on to old debug code. --- AK/Debug.h.in | 4 ---- Meta/CMake/all_the_debug_macros.cmake | 1 - Userland/Services/CrashDaemon/main.cpp | 11 ----------- 3 files changed, 16 deletions(-) diff --git a/AK/Debug.h.in b/AK/Debug.h.in index 3b936c4e3d..5b0d8178d3 100644 --- a/AK/Debug.h.in +++ b/AK/Debug.h.in @@ -14,10 +14,6 @@ #cmakedefine01 AFLACLOADER_DEBUG #endif -#ifndef BACKTRACE_DEBUG -#cmakedefine01 BACKTRACE_DEBUG -#endif - #ifndef BMP_DEBUG #cmakedefine01 BMP_DEBUG #endif diff --git a/Meta/CMake/all_the_debug_macros.cmake b/Meta/CMake/all_the_debug_macros.cmake index 288bbd6353..14bca912c3 100644 --- a/Meta/CMake/all_the_debug_macros.cmake +++ b/Meta/CMake/all_the_debug_macros.cmake @@ -5,7 +5,6 @@ set(APIC_SMP_DEBUG ON) set(ARP_DEBUG ON) set(AWAVLOADER_DEBUG ON) set(AFLACLOADER_DEBUG ON) -set(BACKTRACE_DEBUG ON) set(BBFS_DEBUG ON) set(BMP_DEBUG ON) set(BXVGA_DEBUG ON) diff --git a/Userland/Services/CrashDaemon/main.cpp b/Userland/Services/CrashDaemon/main.cpp index c8b314b10e..6ab73070cf 100644 --- a/Userland/Services/CrashDaemon/main.cpp +++ b/Userland/Services/CrashDaemon/main.cpp @@ -75,18 +75,7 @@ static void print_backtrace(const String& coredump_path) dbgln(); dbgln("--- Backtrace for thread #{} (TID {}) ---", thread_index, thread_info.tid); for (auto& entry : backtrace.entries()) { -#ifndef BACKTRACE_DEBUG dbgln("{}", entry.to_string(true)); -#else - auto region = coredump->region_containing(entry.eip); - String name; - u32 base_addr { 0 }; - if (region) { - name = region->region_name; - base_addr = region->region_start; - } - dbgln("{} ({} base: {:p}, offset: {:p})", entry.to_string(true), name, base_addr, entry.eip - base_addr); -#endif } ++thread_index; return IterationDecision::Continue;