RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:17:44 +00:00
Code Issues Activity Actions

Revert "LibJS: Don't hoist functions under certain circumstances"

Browse source 
This reverts commit 3411d50737.

It was causing LeakSanitizer on CI to fail, possibly due to a circular
reference.
This commit is contained in:
Linus Groh 2021-07-06 12:21:12 +01:00
parent 73183ee5c4
commit 3faeabf1dc
4 changed files with 8 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Parser.h
View file

@ -201,18 +201,12 @@ private:
Function,
Block,
};
struct HoistableDeclaration {
NonnullRefPtr<FunctionDeclaration> declaration;
NonnullRefPtr<Scope> scope; // where it is actually declared
};
Type type;
RefPtr<Scope> parent;
NonnullRefPtrVector<FunctionDeclaration> function_declarations;
Vector<HoistableDeclaration> hoisted_function_declarations;
HashTable<FlyString> lexical_declarations;
NonnullRefPtrVector<FunctionDeclaration> hoisted_function_declarations;
explicit Scope(Type, RefPtr<Scope>);
RefPtr<Scope> get_current_function_scope();