1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 07:57:46 +00:00

LibCore: Return ErrorOr<pid_t> and support arguments in Process::spawn

This makes the wrapper more like the rest in LibCore, and also
removes the annoying limitation of not supporting arguments.

There are three overloads one for String, char const *, and StringView
argument lists. As long as there are <= 10 arguments the argv list
will be allocated inline, otherwise on the heap.
This commit is contained in:
MacDue 2022-05-10 00:24:15 +01:00 committed by Linus Groh
parent 0295d79339
commit 3fc0350caf
11 changed files with 77 additions and 28 deletions

View file

@ -302,7 +302,7 @@ void BrowserWindow::build_menus()
settings_menu.add_separator();
auto open_settings_action = GUI::Action::create("&Settings", Gfx::Bitmap::try_load_from_file("/res/icons/16x16/settings.png").release_value_but_fixme_should_propagate_errors(),
[](auto&) {
Core::Process::spawn("/bin/BrowserSettings");
MUST(Core::Process::spawn("/bin/BrowserSettings"));
});
settings_menu.add_action(move(open_settings_action));

View file

@ -104,7 +104,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto launch_origin_rect = icon_view->to_widget_rect(icon_view->content_rect(index)).translated(icon_view->screen_relative_rect().location());
setenv("__libgui_launch_origin_rect", String::formatted("{},{},{},{}", launch_origin_rect.x(), launch_origin_rect.y(), launch_origin_rect.width(), launch_origin_rect.height()).characters(), 1);
Core::Process::spawn(executable);
MUST(Core::Process::spawn(executable));
};
auto statusbar = TRY(main_widget->try_add<GUI::Statusbar>());

View file

@ -328,7 +328,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto open_settings_action = GUI::Action::create("&Settings", Gfx::Bitmap::try_load_from_file("/res/icons/16x16/settings.png").release_value_but_fixme_should_propagate_errors(),
[&](auto&) {
Core::Process::spawn("/bin/TerminalSettings");
MUST(Core::Process::spawn("/bin/TerminalSettings"));
});
TRY(terminal->context_menu().try_add_separator());
@ -336,7 +336,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto file_menu = TRY(window->try_add_menu("&File"));
TRY(file_menu->try_add_action(GUI::Action::create("Open New &Terminal", { Mod_Ctrl | Mod_Shift, Key_N }, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/app-terminal.png").release_value_but_fixme_should_propagate_errors(), [&](auto&) {
Core::Process::spawn("/bin/Terminal");
MUST(Core::Process::spawn("/bin/Terminal"));
})));
TRY(file_menu->try_add_action(open_settings_action));

View file

@ -54,7 +54,7 @@ WelcomeWidget::WelcomeWidget()
m_help_button = *find_descendant_of_type_named<GUI::Button>("help_button");
m_help_button->set_icon(Gfx::Bitmap::try_load_from_file("/res/icons/16x16/book-open.png").release_value_but_fixme_should_propagate_errors());
m_help_button->on_click = [](auto) {
Core::Process::spawn("/bin/Help"sv);
MUST(Core::Process::spawn("/bin/Help"sv));
};
m_new_button = *find_descendant_of_type_named<GUI::Button>("new_button");