RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:38:10 +00:00
Code Issues Activity Actions

Ladybird: Construct a WebDriverConnection when instructed to do so

Browse source 
The WebDriver will pass the --webdriver-fd-passing-socket command line
option when it launches Ladybird. Forward this flag onto the WebContent
process, where it will create the WebDriverConnection for IPC.
This commit is contained in:
Timothy Flynn 2022-11-14 11:08:44 -05:00 • committed by Andrew Kaster
parent 7021d30288
commit 4031630b49
8 changed files with 38 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Ladybird/Tab.cpp
View file

@ -20,7 +20,7 @@
extern String s_serenity_resource_root;
extern Browser::Settings* s_settings;
Tab::Tab(BrowserWindow* window)
Tab::Tab(BrowserWindow* window, int webdriver_fd_passing_socket)
: QWidget(window)
, m_window(window)
{
@ -28,7 +28,7 @@ Tab::Tab(BrowserWindow* window)
m_layout->setSpacing(0);
m_layout->setContentsMargins(0, 0, 0, 0);
m_view = new WebContentView;
m_view = new WebContentView(webdriver_fd_passing_socket);
m_toolbar = new QToolBar(this);
m_location_edit = new QLineEdit(this);
@ -115,8 +115,13 @@ Tab::Tab(BrowserWindow* window)
// FIXME: This is a hack to make the JS console usable in new windows.
// Something else should ensure that there's an initial about:blank document loaded in the view.
// We set m_is_history_navigation = true so that the initial about:blank doesn't get added to the history.
m_is_history_navigation = true;
m_view->load("about:blank"sv);
//
// Note we *don't* do this if we are connected to a WebDriver, as the Set URL command may come in very
// quickly, and become replaced by this load.
if (webdriver_fd_passing_socket == -1) {
m_is_history_navigation = true;
m_view->load("about:blank"sv);
}
}
void Tab::focus_location_editor()