RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:58:12 +00:00
Code Issues Activity Actions

HackStudio: Decrease the maximal crash frequency of the server to 10 sec

Browse source 
The maximal crash frequency of the language server was previously 3
seconds, but in practice it was too high.
When working with larger projects the language server can get into a
"crash and respawn" loop that takes more than 3 seconds.

10 seconds seems like a reasonable threshold beyond which we no longer
attempt to respawn the server.
This commit is contained in:
Itamar 2021-12-03 09:46:20 +02:00 • committed by Andreas Kling
parent 28ff7d49ad
commit 408f05bbb9
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/HackStudio/LanguageClient.cpp
View file

@ -171,7 +171,7 @@ void ServerConnectionWrapper::on_crash()
show_crash_notification();
m_connection.clear();
static constexpr int max_crash_frequency_seconds = 3;
static constexpr int max_crash_frequency_seconds = 10;
if (m_last_crash_timer.is_valid() && m_last_crash_timer.elapsed() / 1000 < max_crash_frequency_seconds) {
dbgln("LanguageServer crash frequency is too high");
m_respawn_allowed = false;