RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:47:46 +00:00
Code Issues Activity Actions

WebContent+LibWeb+LibJS: Report exceptions to the JS console

Browse source 
Print exceptions passed to `HTML::report_exception` in the JS console

Refactored `ExceptionReporter`: in order to report exception now
you need to pass the relevant realm in it. For passed `JS::Value`
we now create `JS::Error` object to print value as the error message.
This commit is contained in:
Pavel 2022-10-08 19:38:32 +04:00 • committed by Linus Groh
parent 2eb6dbd4f0
commit 40aad77ab1
14 changed files with 86 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Bindings/MainThreadVM.cpp
View file

@ -202,7 +202,7 @@ JS::VM& main_thread_vm()
// 6. If result is an abrupt completion, then report the exception given by result.[[Value]].
if (result.is_error())
HTML::report_exception(result);
HTML::report_exception(result, finalization_registry.realm());
});
};
@ -275,7 +275,7 @@ JS::VM& main_thread_vm()
// 5. If result is an abrupt completion, then report the exception given by result.[[Value]].
if (result.is_error())
HTML::report_exception(result);
HTML::report_exception(result, job_settings->realm());
});
};
@ -437,7 +437,7 @@ void queue_mutation_observer_microtask(DOM::Document& document)
auto result = WebIDL::invoke_callback(callback, mutation_observer.ptr(), wrapped_records, mutation_observer.ptr());
if (result.is_abrupt())
HTML::report_exception(result);
HTML::report_exception(result, realm);
}
}