RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:37:45 +00:00
Code Issues Activity Actions

LibJS: Disallow duplicated variable declarations

Browse source
This commit is contained in:
davidot 2021-07-12 01:29:47 +02:00 • committed by Andreas Kling
parent 5cc518f07a
commit 40b8689f9b
4 changed files with 62 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-setPrototypeOf.js
View file

@ -6,9 +6,9 @@ describe("[[SetPrototypeOf]] trap normal behavior", () => {
let p = new Proxy(o, { setPrototypeOf: null });
expect(Object.setPrototypeOf(p, proto)).toBe(p);
let p = new Proxy(o, { setPrototypeOf: undefined });
p = new Proxy(o, { setPrototypeOf: undefined });
expect(Object.setPrototypeOf(p, proto)).toBe(p);
let p = new Proxy(o, {});
p = new Proxy(o, {});
expect(Object.setPrototypeOf(p, proto)).toBe(p);
});

30
Userland/Libraries/LibJS/Tests/duplicated-variable-declarations.js Normal file
View file

@ -0,0 +1,30 @@
describe("duplicated variable declarations should throw", () => {
test("given two declarations in the same statement", () => {
expect("let a, a;").not.toEval();
expect("const a, a;").not.toEval();
expect("var a, a;").toEval();
});
test("fail to parse if repeated over multiple statements", () => {
expect("let a; var a;").not.toEval();
expect("let b, a; var c, a;").not.toEval();
expect("const a; var a;").not.toEval();
expect("const b, a; var c, a;").not.toEval();
});
test.skip("should fail to parse even if variable first declared with var", () => {
expect.skip("var a; let a;").toEval();
expect.skip("var a; let b, a;").toEval();
expect.skip("var a; const a;").toEval();
expect.skip("var a; const b, a;").toEval();
});
test.skip("special cases with for loops", () => {
expect("for (var a;;) { let a; }").toEval();
expect("for (let a;;) { let a; }").toEval();
expect("for (var a;;) { var a; }").toEval();
expect("for (let a;;) { var a; }").not.toEval();
});
});

4
Userland/Libraries/LibJS/Tests/iterators/string-iterator.js
View file

@ -15,12 +15,12 @@ test("basic functionality", () => {
});
test("casts |this| to string", () => {
const it = String.prototype[Symbol.iterator].call(45);
let it = String.prototype[Symbol.iterator].call(45);
expect(it.next()).toEqual({ value: "4", done: false });
expect(it.next()).toEqual({ value: "5", done: false });
expect(it.next()).toEqual({ value: undefined, done: true });
const it = String.prototype[Symbol.iterator].call(false);
it = String.prototype[Symbol.iterator].call(false);
expect(it.next()).toEqual({ value: "f", done: false });
expect(it.next()).toEqual({ value: "a", done: false });
expect(it.next()).toEqual({ value: "l", done: false });