RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:28:12 +00:00
Code Issues Activity Actions

LibCore: Apply the flags provided to System::pipe2 on all systems

Browse source 
We currently drop the flags on the floor for systems that do not have a
pipe2 syscall. Instead, use fcntl to set the flags.
This commit is contained in:
Timothy Flynn 2024-03-12 14:50:21 -04:00 • committed by Tim Flynn
parent dd271adcf5
commit 40beebca71
1 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibCore/System.cpp
View file

@ -1563,16 +1563,35 @@ ErrorOr<void> socketpair(int domain, int type, int protocol, int sv[2])
return {};
}
ErrorOr<Array<int, 2>> pipe2([[maybe_unused]] int flags)
ErrorOr<Array<int, 2>> pipe2(int flags)
{
Array<int, 2> fds;
#if defined(__unix__)
if (::pipe2(fds.data(), flags) < 0)
return Error::from_syscall("pipe2"sv, -errno);
#else
if (::pipe(fds.data()) < 0)
return Error::from_syscall("pipe2"sv, -errno);
// Ensure we don't leak the fds if any of the system calls below fail.
AK::ArmedScopeGuard close_fds { [&]() {
MUST(close(fds[0]));
MUST(close(fds[1]));
} };
if ((flags & O_CLOEXEC) != 0) {
TRY(fcntl(fds[0], F_SETFD, FD_CLOEXEC));
TRY(fcntl(fds[1], F_SETFD, FD_CLOEXEC));
}
if ((flags & O_NONBLOCK) != 0) {
TRY(fcntl(fds[0], F_SETFL, TRY(fcntl(fds[0], F_GETFL)) | O_NONBLOCK));
TRY(fcntl(fds[1], F_SETFL, TRY(fcntl(fds[1], F_GETFL)) | O_NONBLOCK));
}
close_fds.disarm();
#endif
return fds;
}