RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

ProtocolServer: Don't crash on failed request

Browse source 
The CNetworkJob::on_finish hook will be invoked both for success and
failure, but there will only be a m_job->response() in the success case
so we have to null-check it before using it.

This should have been obvious from the "->"
This commit is contained in:
Andreas Kling 2019-11-30 11:02:14 +01:00
parent b09ac26311
commit 4104f53a94
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Servers/ProtocolServer/HttpDownload.cpp
View file

@ -7,7 +7,8 @@ HttpDownload::HttpDownload(PSClientConnection& client, NonnullRefPtr<CHttpJob>&&
, m_job(job) , m_job(job)
{ {
m_job->on_finish = [this](bool success) { m_job->on_finish = [this](bool success) {
set_payload(m_job->response()->payload()); if (m_job->response())
set_payload(m_job->response()->payload());
did_finish(success); did_finish(success);
}; };
} }