RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

LibWeb: Use Box::has_intrinsic_aspect_ratio() check in FFC step 3

Browse source 
Now that we can ask any Box about its intrinsic aspect ratio, let's fix
a FIXME in FlexFormattingContext.
This commit is contained in:
Andreas Kling 2021-10-14 19:42:09 +02:00
parent a58cc2eeb4
commit 410e2b43ce
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -471,8 +471,7 @@ void FlexFormattingContext::determine_flex_base_size_and_hypothetical_main_size(
// - an intrinsic aspect ratio,
// - a used flex basis of content, and
// - a definite cross size,
bool has_intrinsic_aspect_ratio = false; // FIXME: Populate this.
if (has_intrinsic_aspect_ratio
if (flex_item.box.has_intrinsic_aspect_ratio()
&& used_flex_basis.type == CSS::FlexBasis::Content
&& has_definite_cross_size(child_box)) {
TODO();