RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 14:42:44 +00:00
Code Issues Activity Actions

LibCore+LibGUI: Don't fire timers in non-visible windows by default

Browse source 
LibCore timers now have a TimerShouldFireWhenNotVisible flag which is
set to "No" by default.

If "No", the timer will not be fired by the event loop if it's within
a CObject tree whose nearest GWindow ancestor is currently not visible
for timer purposes. (Specificially, this means that the window is
either minimized or fully occluded, and so does not want to fire timers
just to update the UI.)

This is another nice step towards a calm and serene operating system.
This commit is contained in:
Andreas Kling 2019-12-29 15:58:07 +01:00
parent f8f2b8b520
commit 411d293961
6 changed files with 42 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibCore/CEventLoop.cpp
View file

@ -366,6 +366,11 @@ void CEventLoop::wait_for_event(WaitMode mode)
auto& timer = *it.value;
if (!timer.has_expired(now))
continue;
if (it.value->fire_when_not_visible == TimerShouldFireWhenNotVisible::No
&& it.value->owner
&& !it.value->owner->is_visible_for_timer_purposes()) {
continue;
}
#ifdef CEVENTLOOP_DEBUG
dbg() << "CEventLoop: Timer " << timer.timer_id << " has expired, sending CTimerEvent to " << timer.owner;
#endif
@ -411,13 +416,18 @@ void CEventLoop::get_next_timer_expiration(timeval& soonest)
bool has_checked_any = false;
for (auto& it : *s_timers) {
auto& fire_time = it.value->fire_time;
if (it.value->fire_when_not_visible == TimerShouldFireWhenNotVisible::No
&& it.value->owner
&& !it.value->owner->is_visible_for_timer_purposes()) {
continue;
}
if (!has_checked_any || fire_time.tv_sec < soonest.tv_sec || (fire_time.tv_sec == soonest.tv_sec && fire_time.tv_usec < soonest.tv_usec))
soonest = fire_time;
has_checked_any = true;
}
}
int CEventLoop::register_timer(CObject& object, int milliseconds, bool should_reload)
int CEventLoop::register_timer(CObject& object, int milliseconds, bool should_reload, TimerShouldFireWhenNotVisible fire_when_not_visible)
{
ASSERT(milliseconds >= 0);
auto timer = make<EventLoopTimer>();
@ -427,6 +437,7 @@ int CEventLoop::register_timer(CObject& object, int milliseconds, bool should_re
gettimeofday(&now, nullptr);
timer->reload(now);
timer->should_reload = should_reload;
timer->fire_when_not_visible = fire_when_not_visible;
int timer_id = ++s_next_timer_id; // FIXME: This will eventually wrap around.
ASSERT(timer_id); // FIXME: Aforementioned wraparound.
timer->timer_id = timer_id;