RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:57:34 +00:00
Code Issues Activity Actions

LibCore: Simplify Core::Notifier by only allowing one event type

Browse source 
Not a single client of this API actually used the event mask feature to
listen for readability AND writability.

Let's simplify the API and have only one hook: on_activation.
This commit is contained in:
Andreas Kling 2023-04-23 20:59:32 +02:00
parent 1587caef84
commit 411d36719e
24 changed files with 80 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/FileManager/FileOperationProgressWidget.cpp
View file

@ -69,8 +69,8 @@ FileOperationProgressWidget::FileOperationProgressWidget(FileOperation operation
VERIFY_NOT_REACHED();
}
m_notifier = Core::Notifier::construct(helper_pipe_fd, Core::Notifier::Read);
m_notifier->on_ready_to_read = [this] {
m_notifier = Core::Notifier::construct(helper_pipe_fd, Core::Notifier::Type::Read);
m_notifier->on_activation = [this] {
auto line_buffer_or_error = ByteBuffer::create_zeroed(1 * KiB);
if (line_buffer_or_error.is_error()) {
did_error("Failed to allocate ByteBuffer for reading data."sv);
@ -211,7 +211,7 @@ void FileOperationProgressWidget::close_pipe()
m_helper_pipe = nullptr;
if (m_notifier) {
m_notifier->set_enabled(false);
m_notifier->on_ready_to_read = nullptr;
m_notifier->on_activation = nullptr;
}
m_notifier = nullptr;
}