RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:27:34 +00:00
Code Issues Activity Actions

LibCore: Simplify Core::Notifier by only allowing one event type

Browse source 
Not a single client of this API actually used the event mask feature to
listen for readability AND writability.

Let's simplify the API and have only one hook: on_activation.
This commit is contained in:
Andreas Kling 2023-04-23 20:59:32 +02:00
parent 1587caef84
commit 411d36719e
24 changed files with 80 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Userland/Libraries/LibCore/Event.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2018-2023, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
@ -21,8 +21,7 @@ public:
Invalid = 0,
Quit,
Timer,
NotifierRead,
NotifierWrite,
NotifierActivation,
DeferredInvoke,
ChildAdded,
ChildRemoved,
@ -79,29 +78,14 @@ private:
int m_timer_id;
};
class NotifierReadEvent final : public Event {
class NotifierActivationEvent final : public Event {
public:
explicit NotifierReadEvent(int fd)
: Event(Event::NotifierRead)
explicit NotifierActivationEvent(int fd)
: Event(Event::NotifierActivation)
, m_fd(fd)
{
}
~NotifierReadEvent() = default;
int fd() const { return m_fd; }
private:
int m_fd;
};
class NotifierWriteEvent final : public Event {
public:
explicit NotifierWriteEvent(int fd)
: Event(Event::NotifierWrite)
, m_fd(fd)
{
}
~NotifierWriteEvent() = default;
~NotifierActivationEvent() = default;
int fd() const { return m_fd; }