RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:47:44 +00:00
Code Issues Activity Actions

Piano: Cache buffers in Track and WaveWidget

Browse source 
The Track itself caches the Samples after each processing step which
allows it to be queried without the need to process it every time.

This result is queried by the WaveWidget which then caches the result to
prevent unnecessary heap allocations every paint event.
This commit is contained in:
Fabian Neundorf 2023-03-12 21:03:56 +01:00 • committed by Jelle Raaijmakers
parent 885e35e92c
commit 413e212ea8
5 changed files with 51 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Userland/Libraries/LibDSP/Track.cpp
View file

@ -14,6 +14,7 @@
#include <LibDSP/Music.h>
#include <LibDSP/Processor.h>
#include <LibDSP/Track.h>
#include <unistd.h>
namespace DSP {
@ -64,6 +65,12 @@ bool NoteTrack::check_processor_chain_valid() const
ErrorOr<void> Track::resize_internal_buffers_to(size_t buffer_size)
{
m_secondary_sample_buffer = TRY(FixedArray<Sample>::create(buffer_size));
FixedArray<Sample> cache = TRY(FixedArray<Sample>::create(buffer_size));
bool false_variable = false;
while (!m_sample_lock.compare_exchange_strong(false_variable, true))
usleep(1);
m_cached_sample_buffer.swap(cache);
m_sample_lock.store(false);
return {};
}
@ -92,6 +99,25 @@ void Track::current_signal(FixedArray<Sample>& output_signal)
VERIFY(output_signal.size() == source_signal->get<FixedArray<Sample>>().size());
// The last processor is the fixed mastering processor. This can write directly to the output data. We also just trust this processor that it does the right thing :^)
m_track_mastering->process_to_fixed_array(*source_signal, output_signal);
bool false_variable = false;
if (m_sample_lock.compare_exchange_strong(false_variable, true)) {
AK::TypedTransfer<Sample>::copy(m_cached_sample_buffer.data(), output_signal.data(), m_cached_sample_buffer.size());
m_sample_lock.store(false);
}
}
void Track::write_cached_signal_to(Span<Sample> output_signal)
{
bool false_variable = false;
while (!m_sample_lock.compare_exchange_strong(false_variable, true)) {
usleep(1);
}
VERIFY(output_signal.size() == m_cached_sample_buffer.size());
AK::TypedTransfer<Sample>::copy(output_signal.data(), m_cached_sample_buffer.data(), m_cached_sample_buffer.size());
m_sample_lock.store(false);
}
void NoteTrack::compute_current_clips_signal()