RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 11:25:09 +00:00
Code Issues Activity Actions

Spreadsheet: Allow integer() to throw in weird cases

Browse source 
Also makes numericResolve use parseInt to avoid using our own integer()
This commit is contained in:
u9g 2022-03-04 02:30:37 +00:00 • committed by Ali Mohammad Pur
parent 75a02300ba
commit 4147b56e79
2 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Base/res/js/Spreadsheet/runtime.js
View file

@ -365,6 +365,9 @@ function randRange(min, max) {
}
function integer(value) {
const typeVal = typeof value;
if ((typeVal !== "number" && typeVal !== "string") || Number.isNaN(Number(value)))
throw new Error(`integer() called with unexpected type "${typeVal}"`);
return value | 0;
}
@ -381,7 +384,7 @@ function numericReduce(op, accumulator, cells) {
}
function numericResolve(cells) {
return resolve(cells).map(str => (str === "" || str == null ? NaN : integer(str)));
return resolve(cells).map(val => parseInt(val));
}
function resolve(cells) {