RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:37:35 +00:00
Code Issues Activity Actions

LibJS: Allow out-of-order date ranges to be formatted

Browse source 
This is a normative change to the Intl spec:
769df4b
This commit is contained in:
Timothy Flynn 2022-07-26 06:38:35 -04:00 • committed by Tim Flynn
parent 16d189e96b
commit 415742ab98
4 changed files with 60 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibJS/Tests/builtins/Intl/DateTimeFormat/DateTimeFormat.prototype.formatRange.js
View file

@ -36,12 +36,6 @@ describe("errors", () => {
}).toThrowWithMessage(RangeError, "Time value must be between -8.64E15 and 8.64E15");
});
});
test("called with values in bad order", () => {
expect(() => {
Intl.DateTimeFormat().formatRange(new Date(2021), new Date(1989));
}).toThrowWithMessage(RangeError, "Start time 2021 is after end time 1989");
});
});
const d0 = Date.UTC(1989, 0, 23, 7, 8, 9, 45);
@ -157,6 +151,14 @@ describe("dateStyle", () => {
expect(ja.formatRange(d0, d1)).toBe(d.ja);
});
});
test("dates in reverse order", () => {
const en = new Intl.DateTimeFormat("en", { dateStyle: "full", timeZone: "UTC" });
expect(en.formatRange(d1, d0)).toBe("Tuesday, December 7, 2021 – Monday, January 23, 1989");
const ja = new Intl.DateTimeFormat("ja", { dateStyle: "full", timeZone: "UTC" });
expect(ja.formatRange(d1, d0)).toBe("2021年12月7日火曜日～1989年1月23日月曜日");
});
});
describe("timeStyle", () => {

46
Userland/Libraries/LibJS/Tests/builtins/Intl/DateTimeFormat/DateTimeFormat.prototype.formatRangeToParts.js
View file

@ -36,12 +36,6 @@ describe("errors", () => {
}).toThrowWithMessage(RangeError, "Time value must be between -8.64E15 and 8.64E15");
});
});
test("called with values in bad order", () => {
expect(() => {
Intl.DateTimeFormat().formatRangeToParts(new Date(2021), new Date(1989));
}).toThrowWithMessage(RangeError, "Start time 2021 is after end time 1989");
});
});
const d0 = Date.UTC(1989, 0, 23, 7, 8, 9, 45);
@ -343,6 +337,46 @@ describe("dateStyle", () => {
{ type: "day", value: "07", source: "endRange" },
]);
});
test("dates in reverse order", () => {
const en = new Intl.DateTimeFormat("en", { dateStyle: "full", timeZone: "UTC" });
expect(en.formatRangeToParts(d1, d0)).toEqual([
{ type: "weekday", value: "Tuesday", source: "startRange" },
{ type: "literal", value: ", ", source: "startRange" },
{ type: "month", value: "December", source: "startRange" },
{ type: "literal", value: " ", source: "startRange" },
{ type: "day", value: "7", source: "startRange" },
{ type: "literal", value: ", ", source: "startRange" },
{ type: "year", value: "2021", source: "startRange" },
{ type: "literal", value: " – ", source: "shared" },
{ type: "weekday", value: "Monday", source: "endRange" },
{ type: "literal", value: ", ", source: "endRange" },
{ type: "month", value: "January", source: "endRange" },
{ type: "literal", value: " ", source: "endRange" },
{ type: "day", value: "23", source: "endRange" },
{ type: "literal", value: ", ", source: "endRange" },
{ type: "year", value: "1989", source: "endRange" },
]);
const ja = new Intl.DateTimeFormat("ja", { dateStyle: "full", timeZone: "UTC" });
expect(ja.formatRangeToParts(d1, d0)).toEqual([
{ type: "year", value: "2021", source: "startRange" },
{ type: "literal", value: "年", source: "startRange" },
{ type: "month", value: "12", source: "startRange" },
{ type: "literal", value: "月", source: "startRange" },
{ type: "day", value: "7", source: "startRange" },
{ type: "literal", value: "日", source: "startRange" },
{ type: "weekday", value: "火曜日", source: "startRange" },
{ type: "literal", value: "～", source: "shared" },
{ type: "year", value: "1989", source: "endRange" },
{ type: "literal", value: "年", source: "endRange" },
{ type: "month", value: "1", source: "endRange" },
{ type: "literal", value: "月", source: "endRange" },
{ type: "day", value: "23", source: "endRange" },
{ type: "literal", value: "日", source: "endRange" },
{ type: "weekday", value: "月曜日", source: "endRange" },
]);
});
});
describe("timeStyle", () => {