RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:47:46 +00:00
Code Issues Activity Actions

LibWeb: Support range syntax for media queries

Browse source 
This means you can now do queries like:

```css
@media (400px <= width < 800px) { }
```

Chromium and Firefox which I tested with both don't support this yet, so
that's cool. :^)
This commit is contained in:
Sam Atkins 2022-01-01 16:24:43 +00:00 • committed by Andreas Kling
parent c3bf9e5b79
commit 416033a660
4 changed files with 366 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

46
Userland/Libraries/LibWeb/CSS/MediaQuery.h
View file

@ -72,6 +72,14 @@ private:
// https://www.w3.org/TR/mediaqueries-4/#mq-features
class MediaFeature {
public:
enum class Comparison {
Equal,
LessThan,
LessThanOrEqual,
GreaterThan,
GreaterThanOrEqual,
};
// Corresponds to `<mf-boolean>` grammar
static MediaFeature boolean(String const& name)
{
@ -88,16 +96,40 @@ public:
return MediaFeature(Type::ExactValue, move(name), move(value));
}
// Corresponds to `<mf-range>` grammar, with a single comparison
static MediaFeature half_range(MediaFeatureValue value, Comparison comparison, String const& name)
{
MediaFeature feature { Type::Range, name };
feature.m_range = Range {
.left_value = value,
.left_comparison = comparison,
};
return feature;
}
// Corresponds to `<mf-range>` grammar, with two comparisons
static MediaFeature range(MediaFeatureValue left_value, Comparison left_comparison, String const& name, Comparison right_comparison, MediaFeatureValue right_value)
{
MediaFeature feature { Type::Range, name };
feature.m_range = Range {
.left_value = left_value,
.left_comparison = left_comparison,
.right_comparison = right_comparison,
.right_value = right_value,
};
return feature;
}
bool evaluate(DOM::Window const&) const;
String to_string() const;
private:
// FIXME: Implement range syntax: https://www.w3.org/TR/mediaqueries-4/#mq-ranges
enum class Type {
IsTrue,
ExactValue,
MinValue,
MaxValue,
Range,
};
MediaFeature(Type type, FlyString name, Optional<MediaFeatureValue> value = {})
@ -107,9 +139,19 @@ private:
{
}
static bool compare(MediaFeatureValue left, Comparison comparison, MediaFeatureValue right);
struct Range {
MediaFeatureValue left_value;
Comparison left_comparison;
Optional<Comparison> right_comparison {};
Optional<MediaFeatureValue> right_value {};
};
Type m_type;
FlyString m_name;
Optional<MediaFeatureValue> m_value {};
Optional<Range> m_range {};
};
// https://www.w3.org/TR/mediaqueries-4/#media-conditions
@ -189,6 +231,8 @@ private:
String serialize_a_media_query_list(NonnullRefPtrVector<MediaQuery> const&);
bool is_media_feature_name(StringView name);
}
namespace AK {