RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:17:35 +00:00
Code Issues Activity Actions

Kernel: Remove KDSETMODE and KDGETMODE ioctl options from the TTY class

Browse source 
These options are not relevant and are actually meaningless on pure TTY
devices, as they are meant to be effective only for the VirtualConsole
devices.

This also removes the virtual marking from two methods because they're
no longer declared in the TTY class as well.
This commit is contained in:
Liav A 2023-08-25 10:05:40 +03:00 • committed by Tim Schumacher
parent 258af88b29
commit 4177e6be8b
4 changed files with 25 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/TTY/TTY.h
View file

@ -25,7 +25,7 @@ public:
virtual ErrorOr<size_t> write(OpenFileDescription&, u64, UserOrKernelBuffer const&, size_t) override;
virtual bool can_read(OpenFileDescription const&, u64) const override;
virtual bool can_write(OpenFileDescription const&, u64) const override;
virtual ErrorOr<void> ioctl(OpenFileDescription&, unsigned request, Userspace<void*> arg) override final;
virtual ErrorOr<void> ioctl(OpenFileDescription&, unsigned request, Userspace<void*> arg) override;
unsigned short rows() const { return m_rows; }
unsigned short columns() const { return m_columns; }
@ -48,9 +48,6 @@ public:
virtual ErrorOr<NonnullOwnPtr<KString>> pseudo_name() const = 0;
virtual bool is_graphical() const { return false; }
virtual void set_graphical(bool) { }
protected:
virtual ErrorOr<size_t> on_tty_write(UserOrKernelBuffer const&, size_t) = 0;
void set_size(unsigned short columns, unsigned short rows);