1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:58:11 +00:00

LibJS: Fix syntax error for arrow function non-decl variable assignment

A regression was introduced in dc9b4da where the parser would
incorrectly parse the assignment of arrow functions to (non-declaration)
variables. For example, consider:

    a = () => {}

Because the parser was aware of default parameters, in
try_parse_arrow_function, the equals sign would be interpreted as a
default argument, leading to incorrect parsing of the overall
expression. Also resulted in some funny behavior
(a = () => {} => {} worked just fine!).

The simple fix is to only look for default parameters if the arrow
function is required to have parenthesis.
This commit is contained in:
Matthew Olsson 2020-05-05 18:05:50 -07:00 committed by Andreas Kling
parent 3142c4a4fd
commit 419bce6915
2 changed files with 4 additions and 1 deletions

View file

@ -295,7 +295,7 @@ RefPtr<FunctionExpression> Parser::try_parse_arrow_function_expression(bool expe
} else if (match(TokenType::Identifier)) {
auto parameter_name = consume(TokenType::Identifier).value();
RefPtr<Expression> default_value;
if (match(TokenType::Equals)) {
if (expect_parens && match(TokenType::Equals)) {
consume(TokenType::Equals);
default_value = parse_expression(0);
}