1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:37:35 +00:00

LibJS: Fix syntax error for arrow function non-decl variable assignment

A regression was introduced in dc9b4da where the parser would
incorrectly parse the assignment of arrow functions to (non-declaration)
variables. For example, consider:

    a = () => {}

Because the parser was aware of default parameters, in
try_parse_arrow_function, the equals sign would be interpreted as a
default argument, leading to incorrect parsing of the overall
expression. Also resulted in some funny behavior
(a = () => {} => {} worked just fine!).

The simple fix is to only look for default parameters if the arrow
function is required to have parenthesis.
This commit is contained in:
Matthew Olsson 2020-05-05 18:05:50 -07:00 committed by Andreas Kling
parent 3142c4a4fd
commit 419bce6915
2 changed files with 4 additions and 1 deletions

View file

@ -4,6 +4,9 @@ try {
let getNumber = () => 42;
assert(getNumber() === 42);
getNumber = () => 99;
assert(getNumber() === 99);
let add = (a, b) => a + b;
assert(add(2, 3) === 5);