RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:27:46 +00:00
Code Issues Activity Actions

LibWeb: Make HTML::DecodedImageData to be GC-allocated

Browse source 
This change fixes GC-leak caused by following mutual dependency:
- SVGDecodedImageData owns JS::Handle for Page.
- SVGDecodedImageData is owned by visited objects.
by making everything inherited from HTML::DecodedImageData and
ListOfAvailableImages to be GC-allocated.

Generally, if visited object has a handle, very likely we leak
everything visited from object in a handle.
This commit is contained in:
Aliaksandr Kalenik 2023-12-12 20:07:19 +01:00 • committed by Andreas Kling
parent 57a04c536c
commit 41a3c19cfe
18 changed files with 100 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -347,7 +347,7 @@ void Document::initialize(JS::Realm& realm)
m_selection = heap().allocate<Selection::Selection>(realm, realm, *this);
m_list_of_available_images = make<HTML::ListOfAvailableImages>();
m_list_of_available_images = heap().allocate<HTML::ListOfAvailableImages>(realm);
}
void Document::visit_edges(Cell::Visitor& visitor)
@ -413,6 +413,8 @@ void Document::visit_edges(Cell::Visitor& visitor)
for (auto& timeline : m_associated_animation_timelines)
visitor.visit(timeline);
visitor.visit(m_list_of_available_images);
}
// https://w3c.github.io/selection-api/#dom-document-getselection