mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 21:57:43 +00:00
LibWeb: Make HTML::DecodedImageData to be GC-allocated
This change fixes GC-leak caused by following mutual dependency: - SVGDecodedImageData owns JS::Handle for Page. - SVGDecodedImageData is owned by visited objects. by making everything inherited from HTML::DecodedImageData and ListOfAvailableImages to be GC-allocated. Generally, if visited object has a handle, very likely we leak everything visited from object in a handle.
This commit is contained in:
parent
57a04c536c
commit
41a3c19cfe
18 changed files with 100 additions and 54 deletions
|
@ -28,7 +28,7 @@ public:
|
|||
|
||||
AK::URL const& url() const { return m_url; }
|
||||
|
||||
[[nodiscard]] RefPtr<DecodedImageData const> image_data() const;
|
||||
[[nodiscard]] JS::GCPtr<DecodedImageData> image_data() const;
|
||||
|
||||
[[nodiscard]] JS::GCPtr<Fetch::Infrastructure::FetchController> fetch_controller();
|
||||
void set_fetch_controller(JS::GCPtr<Fetch::Infrastructure::FetchController>);
|
||||
|
@ -66,7 +66,7 @@ private:
|
|||
Vector<Callbacks> m_callbacks;
|
||||
|
||||
AK::URL m_url;
|
||||
RefPtr<DecodedImageData const> m_image_data;
|
||||
JS::GCPtr<DecodedImageData> m_image_data;
|
||||
JS::GCPtr<Fetch::Infrastructure::FetchController> m_fetch_controller;
|
||||
|
||||
JS::GCPtr<DOM::Document> m_document;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue