RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:37:36 +00:00
Code Issues Activity Actions

Meta+Documentation: Require Xcode 14.3 or Clang 14 for the host compiler

Browse source 
There have been multiple reports of Xcode 14.0 (based on upstream LLVM
14) segfaulting when compiling `LibCore/Process.cpp`. Let's require
Xcode 14.3, which is a known good version based on LLVM 15.

Note that Xcode 14.3 requires macOS Ventura, so users of Monterey or
older are expected to get Homebrew Clang instead.

Homebrew Clang 13 also suffers from the same crash. Although I have not
tested on Linux, the backtrace points to the middle-end, so x86_64 is
also likely to be affected. LLVM 14 was released 14 months ago, so it's
not an unreasonable requirement.
This commit is contained in:
Daniel Bertalan 2023-05-21 11:04:47 +02:00 • committed by Andrew Kaster
parent e5618b17c4
commit 4202bb597b
6 changed files with 20 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Meta/serenity.sh
View file

@ -152,10 +152,12 @@ is_supported_compiler() {
MAJOR_VERSION="${VERSION%%.*}"
if $COMPILER --version 2>&1 | grep "Apple clang" >/dev/null; then
# Apple Clang version check
[ "$MAJOR_VERSION" -ge 14 ] && return 0
BUILD_VERSION=$(echo | $COMPILER -dM -E - | grep __apple_build_version__ | cut -d ' ' -f3)
# Xcode 14.3, based on upstream LLVM 15
[ "$BUILD_VERSION" -ge 14030022 ] && return 0
elif $COMPILER --version 2>&1 | grep "clang" >/dev/null; then
# Clang version check
[ "$MAJOR_VERSION" -ge 13 ] && return 0
[ "$MAJOR_VERSION" -ge 14 ] && return 0
else
# GCC version check
[ "$MAJOR_VERSION" -ge 12 ] && return 0
@ -189,7 +191,7 @@ pick_host_compiler() {
return
fi
find_newest_compiler clang clang-13 clang-14 clang-15 /opt/homebrew/opt/llvm/bin/clang
find_newest_compiler clang clang-14 clang-15 /opt/homebrew/opt/llvm/bin/clang
if is_supported_compiler "$HOST_COMPILER"; then
export CC="${HOST_COMPILER}"
export CXX="${HOST_COMPILER/clang/clang++}"
@ -203,7 +205,11 @@ pick_host_compiler() {
return
fi
die "Please make sure that GCC version 12, Clang version 13, or higher is installed."
if [ "$(uname -s)" = "Darwin" ]; then
die "Please make sure that Xcode 14.3, Homebrew Clang 14, or higher is installed."
else
die "Please make sure that GCC version 12, Clang version 14, or higher is installed."
fi
}
cmd_with_target() {