RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:07:45 +00:00
Code Issues Activity Actions

LibGfx: Use the Midpoint Ellipse Algorithm

Browse source 
It is only used to draw non-antialiased and non-filled ellipses.
This commit is contained in:
Lucas CHOLLET 2022-11-08 17:07:14 +01:00 • committed by Andreas Kling
parent 09841f56ed
commit 4219d50a21
2 changed files with 51 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Applications/PixelPaint/Tools/EllipseTool.cpp
View file

@ -37,17 +37,10 @@ void EllipseTool::draw_using(GUI::Painter& painter, Gfx::IntPoint const& start_p
switch (m_fill_mode) {
case FillMode::Outline:
if (m_antialias_enabled) {
if (m_antialias_enabled)
aa_painter.draw_ellipse(ellipse_intersecting_rect, m_editor->color_for(m_drawing_button), thickness);
} else {
// For some reason for non-AA draw_ellipse() the ellipse is outside of the rect (unlike all other ellipse drawing functions).
// Scale the ellipse rect by sqrt(2) to get an ellipse arc that appears as if it was inside of the rect.
// Ie. reduce the size by a factor of 1 - sqrt(1/2)
auto shrink_width = ellipse_intersecting_rect.width() * (1 - AK::Sqrt1_2<float>);
auto shrink_height = ellipse_intersecting_rect.height() * (1 - AK::Sqrt1_2<float>);
ellipse_intersecting_rect.shrink(shrink_width, shrink_height);
else
painter.draw_ellipse_intersecting(ellipse_intersecting_rect, m_editor->color_for(m_drawing_button), thickness);
}
break;
case FillMode::Fill:
if (m_antialias_enabled)