RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:38:11 +00:00
Code Issues Activity Actions

Piano: Make decay more accurate

Browse source 
1. Make decay sample-granular rather than buffer-granular
You only have ~43 buffers per second which can make a jagged signal.

2. Calculate decay in milliseconds
Decay is supposed to be a time value.
This commit is contained in:
William McPherson 2020-02-05 01:36:30 +11:00 • committed by Andreas Kling
parent 44c81ee9db
commit 421a340572
3 changed files with 21 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Applications/Piano/KnobsWidget.cpp
View file

@ -91,7 +91,7 @@ KnobsWidget::KnobsWidget(GUI::Widget* parent, AudioEngine& audio_engine, MainWid
m_wave_value->set_text(wave_strings[new_wave]);
};
constexpr int max_decay = 20;
constexpr int max_decay = 1000;
m_decay_knob = GUI::Slider::construct(Orientation::Vertical, m_knobs_container);
m_decay_knob->set_range(0, max_decay);
m_decay_knob->set_value(max_decay - m_audio_engine.decay());