RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:08:10 +00:00
Code Issues Activity Actions

LibJS: Defer Value construction until a Literal is executed

Browse source 
Remove the need to construct a full Value during parsing. This means
we don't have to worry about plumbing the heap into the parser.

The Literal ASTNode now has a bunch of subclasses that synthesize a
Value on demand.
This commit is contained in:
Andreas Kling 2020-03-12 12:19:11 +01:00
parent 4d942cc1d0
commit 425fd3ce51
3 changed files with 73 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Parser.cpp
View file

@ -86,9 +86,9 @@ NonnullOwnPtr<Expression> Parser::parse_primary_expression()
case TokenType::Identifier:
return make<Identifier>(consume().value());
case TokenType::NumericLiteral:
return make<Literal>(Value(consume().double_value()));
return make<NumericLiteral>(consume().double_value());
case TokenType::BoolLiteral:
return make<Literal>(Value(consume().bool_value()));
return make<BooleanLiteral>(consume().bool_value());
case TokenType::CurlyOpen:
return parse_object_expression();
default: