RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 22:02:44 +00:00
Code Issues Activity Actions

LibDesktop: Don't resolve relative URL's, expect absolute URLs instead

Browse source 
It's not our job in LibDesktop to resolve relative URLs on behalf of
callers, so let's just not do that. :^)
This commit is contained in:
Andreas Kling 2020-05-09 16:14:56 +02:00
parent 15601988a4
commit 427863f275
1 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibDesktop/Launcher.cpp
View file

@ -47,7 +47,6 @@ private:
LaunchServerConnection() LaunchServerConnection()
: IPC::ServerConnection<LaunchClientEndpoint, LaunchServerEndpoint>(*this, "/tmp/portal/launch") : IPC::ServerConnection<LaunchClientEndpoint, LaunchServerEndpoint>(*this, "/tmp/portal/launch")
{ {
} }
virtual void handle(const Messages::LaunchClient::Dummy&) override {} virtual void handle(const Messages::LaunchClient::Dummy&) override {}
}; };
@ -55,18 +54,6 @@ private:
bool Launcher::open(const URL& url) bool Launcher::open(const URL& url)
{ {
auto connection = LaunchServerConnection::construct(); auto connection = LaunchServerConnection::construct();
if (url.protocol() == "file") {
// Make the path fully qualified - LaunchServer won't know our cwd
char* path = realpath(url.path().characters(), nullptr);
if (path == nullptr) {
return false;
}
auto fully_qualified = URL::create_with_file_protocol(path);
free(path);
return connection->send_sync<Messages::LaunchServer::OpenUrl>(fully_qualified.to_string());
}
return connection->send_sync<Messages::LaunchServer::OpenUrl>(url.to_string()); return connection->send_sync<Messages::LaunchServer::OpenUrl>(url.to_string());
} }