1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:17:34 +00:00

LibGUI: Don't require passing a parent to widget constructors

This is a step towards using Core::Object::add<T> more, which takes
care of parenting the newly created child automatically.
This commit is contained in:
Andreas Kling 2020-02-23 09:01:05 +01:00
parent d9e459293b
commit 428582e805
23 changed files with 35 additions and 35 deletions

View file

@ -60,8 +60,8 @@ public:
void set_auto_repeat_interval(int interval) { m_auto_repeat_interval = interval; } void set_auto_repeat_interval(int interval) { m_auto_repeat_interval = interval; }
protected: protected:
explicit AbstractButton(Widget* parent); explicit AbstractButton(Widget* parent = nullptr);
AbstractButton(const StringView&, Widget* parent); AbstractButton(const StringView&, Widget* parent = nullptr);
virtual void mousedown_event(MouseEvent&) override; virtual void mousedown_event(MouseEvent&) override;
virtual void mousemove_event(MouseEvent&) override; virtual void mousemove_event(MouseEvent&) override;

View file

@ -72,7 +72,7 @@ public:
protected: protected:
virtual ~AbstractTableView() override; virtual ~AbstractTableView() override;
explicit AbstractTableView(Widget* parent); explicit AbstractTableView(Widget* parent = nullptr);
virtual void did_update_model() override; virtual void did_update_model() override;
virtual void mouseup_event(MouseEvent&) override; virtual void mouseup_event(MouseEvent&) override;

View file

@ -73,7 +73,7 @@ public:
NonnullRefPtr<Gfx::Font> font_for_index(const ModelIndex&) const; NonnullRefPtr<Gfx::Font> font_for_index(const ModelIndex&) const;
protected: protected:
explicit AbstractView(Widget* parent); explicit AbstractView(Widget* parent = nullptr);
virtual ~AbstractView() override; virtual ~AbstractView() override;
virtual void mousedown_event(MouseEvent&) override; virtual void mousedown_event(MouseEvent&) override;

View file

@ -62,8 +62,8 @@ public:
void set_focusable(bool b) { m_focusable = b; } void set_focusable(bool b) { m_focusable = b; }
protected: protected:
Button(const StringView& text, Widget* parent); Button(const StringView& text, Widget* parent = nullptr);
explicit Button(Widget* parent); explicit Button(Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
private: private:

View file

@ -38,8 +38,8 @@ public:
virtual void click() override; virtual void click() override;
private: private:
CheckBox(const StringView&, Widget* parent); CheckBox(const StringView&, Widget* parent = nullptr);
explicit CheckBox(Widget* parent); explicit CheckBox(Widget* parent = nullptr);
// These don't make sense for a check box, so hide them. // These don't make sense for a check box, so hide them.
using AbstractButton::auto_repeat_interval; using AbstractButton::auto_repeat_interval;

View file

@ -39,8 +39,8 @@ public:
void set_title(const StringView&); void set_title(const StringView&);
protected: protected:
explicit GroupBox(Widget* parent); explicit GroupBox(Widget* parent = nullptr);
GroupBox(const StringView& title, Widget* parent); GroupBox(const StringView& title, Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;

View file

@ -48,7 +48,7 @@ public:
virtual ModelIndex index_at_event_position(const Gfx::Point&) const override; virtual ModelIndex index_at_event_position(const Gfx::Point&) const override;
private: private:
explicit ItemView(Widget* parent); explicit ItemView(Widget* parent = nullptr);
virtual void did_update_model() override; virtual void did_update_model() override;
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;

View file

@ -33,7 +33,7 @@ namespace GUI {
class ListView : public AbstractView { class ListView : public AbstractView {
C_OBJECT(ListView) C_OBJECT(ListView)
public: public:
explicit ListView(Widget* parent); explicit ListView(Widget* parent = nullptr);
virtual ~ListView() override; virtual ~ListView() override;
int item_height() const { return 16; } int item_height() const { return 16; }

View file

@ -56,7 +56,7 @@ public:
void set_format(Format format) { m_format = format; } void set_format(Format format) { m_format = format; }
protected: protected:
explicit ProgressBar(Widget* parent); explicit ProgressBar(Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;

View file

@ -38,8 +38,8 @@ public:
virtual void click() override; virtual void click() override;
protected: protected:
explicit RadioButton(Widget* parent); explicit RadioButton(Widget* parent = nullptr);
explicit RadioButton(const StringView& text, Widget* parent); explicit RadioButton(const StringView& text, Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
private: private:

View file

@ -34,7 +34,7 @@ public:
virtual ~ResizeCorner() override; virtual ~ResizeCorner() override;
protected: protected:
explicit ResizeCorner(Widget* parent); explicit ResizeCorner(Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
virtual void mousedown_event(MouseEvent&) override; virtual void mousedown_event(MouseEvent&) override;

View file

@ -65,8 +65,8 @@ public:
}; };
private: private:
explicit ScrollBar(Widget* parent); explicit ScrollBar(Widget* parent = nullptr);
explicit ScrollBar(Orientation, Widget* parent); explicit ScrollBar(Orientation, Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
virtual void mousedown_event(MouseEvent&) override; virtual void mousedown_event(MouseEvent&) override;

View file

@ -71,7 +71,7 @@ public:
Gfx::Point to_widget_position(const Gfx::Point& content_position) const; Gfx::Point to_widget_position(const Gfx::Point& content_position) const;
protected: protected:
explicit ScrollableWidget(Widget* parent); explicit ScrollableWidget(Widget* parent = nullptr);
virtual void custom_layout() override; virtual void custom_layout() override;
virtual void resize_event(ResizeEvent&) override; virtual void resize_event(ResizeEvent&) override;
virtual void mousewheel_event(MouseEvent&) override; virtual void mousewheel_event(MouseEvent&) override;

View file

@ -106,7 +106,7 @@ public:
virtual ~VerticalSlider() override {} virtual ~VerticalSlider() override {}
private: private:
explicit VerticalSlider(Widget* parent) explicit VerticalSlider(Widget* parent = nullptr)
: Slider(Orientation::Vertical, parent) : Slider(Orientation::Vertical, parent)
{ {
} }
@ -118,7 +118,7 @@ public:
virtual ~HorizontalSlider() override {} virtual ~HorizontalSlider() override {}
private: private:
explicit HorizontalSlider(Widget* parent) explicit HorizontalSlider(Widget* parent = nullptr)
: Slider(Orientation::Horizontal, parent) : Slider(Orientation::Horizontal, parent)
{ {
} }

View file

@ -36,7 +36,7 @@ public:
virtual ~Splitter() override; virtual ~Splitter() override;
protected: protected:
Splitter(Gfx::Orientation, Widget* parent); Splitter(Gfx::Orientation, Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
virtual void resize_event(ResizeEvent&) override; virtual void resize_event(ResizeEvent&) override;
@ -68,7 +68,7 @@ public:
virtual ~VerticalSplitter() override {} virtual ~VerticalSplitter() override {}
private: private:
explicit VerticalSplitter(Widget* parent) explicit VerticalSplitter(Widget* parent = nullptr)
: Splitter(Gfx::Orientation::Vertical, parent) : Splitter(Gfx::Orientation::Vertical, parent)
{ {
} }
@ -80,7 +80,7 @@ public:
virtual ~HorizontalSplitter() override {} virtual ~HorizontalSplitter() override {}
private: private:
explicit HorizontalSplitter(Widget* parent) explicit HorizontalSplitter(Widget* parent = nullptr)
: Splitter(Gfx::Orientation::Horizontal, parent) : Splitter(Gfx::Orientation::Horizontal, parent)
{ {
} }

View file

@ -42,7 +42,7 @@ public:
Function<void(Widget*)> on_active_widget_change; Function<void(Widget*)> on_active_widget_change;
protected: protected:
explicit StackWidget(Widget* parent); explicit StackWidget(Widget* parent = nullptr);
virtual void child_event(Core::ChildEvent&) override; virtual void child_event(Core::ChildEvent&) override;
virtual void resize_event(ResizeEvent&) override; virtual void resize_event(ResizeEvent&) override;

View file

@ -41,8 +41,8 @@ public:
void set_text(int index, const StringView&); void set_text(int index, const StringView&);
protected: protected:
explicit StatusBar(Widget* parent); explicit StatusBar(Widget* parent = nullptr);
explicit StatusBar(int label_count, Widget* parent); explicit StatusBar(int label_count, Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
private: private:

View file

@ -38,7 +38,7 @@ public:
Bottom, Bottom,
}; };
explicit TabWidget(Widget* parent); explicit TabWidget(Widget* parent = nullptr);
virtual ~TabWidget() override; virtual ~TabWidget() override;
TabPosition tab_position() const { return m_tab_position; } TabPosition tab_position() const { return m_tab_position; }

View file

@ -36,7 +36,7 @@ public:
virtual ~TableView() override; virtual ~TableView() override;
protected: protected:
explicit TableView(Widget* parent); explicit TableView(Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
}; };

View file

@ -33,7 +33,7 @@ namespace GUI {
class TextBox : public TextEditor { class TextBox : public TextEditor {
C_OBJECT(TextBox) C_OBJECT(TextBox)
public: public:
explicit TextBox(Widget* parent); explicit TextBox(Widget* parent = nullptr);
virtual ~TextBox() override; virtual ~TextBox() override;
}; };

View file

@ -130,8 +130,8 @@ public:
void set_syntax_highlighter(OwnPtr<SyntaxHighlighter>); void set_syntax_highlighter(OwnPtr<SyntaxHighlighter>);
protected: protected:
explicit TextEditor(Widget* parent); explicit TextEditor(Widget* parent = nullptr);
explicit TextEditor(Type, Widget* parent); explicit TextEditor(Type, Widget* parent = nullptr);
virtual void did_change_font() override; virtual void did_change_font() override;
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;

View file

@ -43,8 +43,8 @@ public:
void set_has_frame(bool has_frame) { m_has_frame = has_frame; } void set_has_frame(bool has_frame) { m_has_frame = has_frame; }
protected: protected:
explicit ToolBar(Widget* parent); explicit ToolBar(Widget* parent = nullptr);
explicit ToolBar(Orientation, int button_size, Widget* parent); explicit ToolBar(Orientation, int button_size, Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;

View file

@ -41,7 +41,7 @@ public:
virtual int item_count() const override; virtual int item_count() const override;
protected: protected:
explicit TreeView(Widget*); explicit TreeView(Widget* parent = nullptr);
virtual void paint_event(PaintEvent&) override; virtual void paint_event(PaintEvent&) override;
virtual void doubleclick_event(MouseEvent&) override; virtual void doubleclick_event(MouseEvent&) override;