From 42870a9494b97593b60e42dcac67dd6f059e53b4 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 20 Jun 2020 18:27:31 +0200 Subject: [PATCH] LibWeb: Add some missing wrapper calls to base class initialize() This is easy to forget, but the problem will go away once we start to auto-generate this code. --- Libraries/LibWeb/Bindings/LocationObject.cpp | 3 ++- Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp | 3 ++- Libraries/LibWeb/Bindings/XMLHttpRequestPrototype.cpp | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Libraries/LibWeb/Bindings/LocationObject.cpp b/Libraries/LibWeb/Bindings/LocationObject.cpp index b453cf4dd5..bb14fa368b 100644 --- a/Libraries/LibWeb/Bindings/LocationObject.cpp +++ b/Libraries/LibWeb/Bindings/LocationObject.cpp @@ -40,8 +40,9 @@ LocationObject::LocationObject(JS::GlobalObject& global_object) { } -void LocationObject::initialize(JS::Interpreter&, JS::GlobalObject&) +void LocationObject::initialize(JS::Interpreter& interpreter, JS::GlobalObject& global_object) { + Object::initialize(interpreter, global_object); u8 attr = JS::Attribute::Writable | JS::Attribute::Enumerable; define_native_property("href", href_getter, href_setter, attr); define_native_property("host", host_getter, nullptr, attr); diff --git a/Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp b/Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp index db1ee42a20..c2682383ec 100644 --- a/Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp +++ b/Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp @@ -41,8 +41,9 @@ XMLHttpRequestConstructor::XMLHttpRequestConstructor(JS::GlobalObject& global_ob { } -void XMLHttpRequestConstructor::initialize(JS::Interpreter&, JS::GlobalObject&) +void XMLHttpRequestConstructor::initialize(JS::Interpreter& interpreter, JS::GlobalObject& global_object) { + NativeFunction::initialize(interpreter, global_object); define_property("length", JS::Value(1), JS::Attribute::Configurable); define_property("UNSENT", JS::Value((i32)XMLHttpRequest::ReadyState::Unsent), JS::Attribute::Enumerable); diff --git a/Libraries/LibWeb/Bindings/XMLHttpRequestPrototype.cpp b/Libraries/LibWeb/Bindings/XMLHttpRequestPrototype.cpp index 079ddcb0dd..85bc482422 100644 --- a/Libraries/LibWeb/Bindings/XMLHttpRequestPrototype.cpp +++ b/Libraries/LibWeb/Bindings/XMLHttpRequestPrototype.cpp @@ -40,8 +40,9 @@ XMLHttpRequestPrototype::XMLHttpRequestPrototype(JS::GlobalObject& global_object { } -void XMLHttpRequestPrototype::initialize(JS::Interpreter&, JS::GlobalObject&) +void XMLHttpRequestPrototype::initialize(JS::Interpreter& interpreter, JS::GlobalObject& global_object) { + Object::initialize(interpreter, global_object); define_native_function("open", open, 2); define_native_function("send", send, 0); define_native_property("readyState", ready_state_getter, nullptr, JS::Attribute::Enumerable | JS::Attribute::Configurable);