RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:07:35 +00:00
Code Issues Activity Actions

Everywhere: Remove redundant inequality comparison operators

Browse source 
C++20 can automatically synthesize `operator!=` from `operator==`, so
there is no point in writing such functions by hand if all they do is
call through to `operator==`.

This fixes a compile error with compilers that implement P2468 (Clang
16 currently). This paper restores the C++17 behavior that if both
`T::operator==(U)` and `T::operator!=(U)` exist, `U == T` won't be
rewritten in reverse to call `T::operator==(U)`. Removing `!=` operators
makes the rewriting possible again.
See https://reviews.llvm.org/D134529#3853062
This commit is contained in:
Daniel Bertalan 2022-10-21 15:53:20 +02:00 • committed by Andrew Kaster
parent 4e406b0730
commit 4296425bd8
40 changed files with 1 additions and 180 deletions
Download patch file Download diff file Expand all files Collapse all files

4
AK/String.h
View file

@ -203,13 +203,10 @@ public:
[[nodiscard]] bool ends_with(char) const;
bool operator==(String const&) const;
bool operator!=(String const& other) const { return !(*this == other); }
bool operator==(StringView) const;
bool operator!=(StringView other) const { return !(*this == other); }
bool operator==(FlyString const&) const;
bool operator!=(FlyString const& other) const { return !(*this == other); }
bool operator<(String const&) const;
bool operator<(char const*) const;
@ -222,7 +219,6 @@ public:
bool operator<=(char const* other) const { return !(*this > other); }
bool operator==(char const* cstring) const;
bool operator!=(char const* cstring) const { return !(*this == cstring); }
[[nodiscard]] String isolated_copy() const;