RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:07:36 +00:00
Code Issues Activity Actions

Everywhere: Remove redundant inequality comparison operators

Browse source 
C++20 can automatically synthesize `operator!=` from `operator==`, so
there is no point in writing such functions by hand if all they do is
call through to `operator==`.

This fixes a compile error with compilers that implement P2468 (Clang
16 currently). This paper restores the C++17 behavior that if both
`T::operator==(U)` and `T::operator!=(U)` exist, `U == T` won't be
rewritten in reverse to call `T::operator==(U)`. Removing `!=` operators
makes the rewriting possible again.
See https://reviews.llvm.org/D134529#3853062
This commit is contained in:
Daniel Bertalan 2022-10-21 15:53:20 +02:00 • committed by Andrew Kaster
parent 4e406b0730
commit 4296425bd8
40 changed files with 1 additions and 180 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibDeviceTree/FlattenedDeviceTree.h
View file

@ -34,7 +34,6 @@ struct FlattenedDeviceTreeReserveEntry {
BigEndian<u64> size;
bool operator==(FlattenedDeviceTreeReserveEntry const& other) const { return other.address == address && other.size == size; }
bool operator!=(FlattenedDeviceTreeReserveEntry const& other) const { return !(operator==(other)); }
};
static_assert(sizeof(FlattenedDeviceTreeReserveEntry) == 16, "FDT Memory Reservation entry size must match specification");