RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 22:02:44 +00:00
Code Issues Activity Actions

LibJS: Use PropertyName::as_string() in Object::get()

Browse source 
After we've already checked is_string(), we can use as_string() to
avoid a temporary String.
This commit is contained in:
Andreas Kling 2021-06-05 12:57:29 +02:00
parent 66f15c2e0c
commit 42fcc2219d
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -765,7 +765,7 @@ Value Object::get(const PropertyName& property_name, Value receiver, bool withou
return get_by_index(property_name.as_number()); return get_by_index(property_name.as_number());
if (property_name.is_string()) { if (property_name.is_string()) {
auto property_string = property_name.to_string(); auto& property_string = property_name.as_string();
i32 property_index = property_string.to_int().value_or(-1); i32 property_index = property_string.to_int().value_or(-1);
if (property_index >= 0) if (property_index >= 0)
return get_by_index(property_index); return get_by_index(property_index);