RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:47:46 +00:00
Code Issues Activity Actions

Kernel: Mark sys$clock_settime() as not needing the big log

Browse source 
This syscall ends up disabling interrupts while changing the time,
and the clock is a global resource anyway, so preventing threads in the
same process from running wouldn't solve anything.
This commit is contained in:
Andreas Kling 2022-04-04 00:12:57 +02:00
parent 55814f6e0e
commit 4306422f29
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -53,7 +53,7 @@ enum class NeedsBigProcessLock {
S(chown, NeedsBigProcessLock::Yes) \ S(chown, NeedsBigProcessLock::Yes) \
S(clock_gettime, NeedsBigProcessLock::No) \ S(clock_gettime, NeedsBigProcessLock::No) \
S(clock_nanosleep, NeedsBigProcessLock::No) \ S(clock_nanosleep, NeedsBigProcessLock::No) \
S(clock_settime, NeedsBigProcessLock::Yes) \ S(clock_settime, NeedsBigProcessLock::No) \
S(close, NeedsBigProcessLock::Yes) \ S(close, NeedsBigProcessLock::Yes) \
S(connect, NeedsBigProcessLock::Yes) \ S(connect, NeedsBigProcessLock::Yes) \
S(create_inode_watcher, NeedsBigProcessLock::Yes) \ S(create_inode_watcher, NeedsBigProcessLock::Yes) \

2
Kernel/Syscalls/clock.cpp
View file

@ -35,7 +35,7 @@ ErrorOr<FlatPtr> Process::sys$clock_gettime(clockid_t clock_id, Userspace<timesp
ErrorOr<FlatPtr> Process::sys$clock_settime(clockid_t clock_id, Userspace<timespec const*> user_ts) ErrorOr<FlatPtr> Process::sys$clock_settime(clockid_t clock_id, Userspace<timespec const*> user_ts)
{ {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); VERIFY_NO_PROCESS_BIG_LOCK(this);
TRY(require_promise(Pledge::settime)); TRY(require_promise(Pledge::settime));
if (!is_superuser()) if (!is_superuser())