From 434d77cd43d12b2f88439c073fe36679cca10554 Mon Sep 17 00:00:00 2001
From: Andreas Kling <kling@serenityos.org>
Date: Tue, 23 Aug 2022 00:58:02 +0200
Subject: [PATCH] Kernel/ProcFS: Silently ignore attempts to update ProcFS
 timestamps

We have to override Inode::update_timestamps() for ProcFS inodes,
otherwise we'll get the default behavior of erroring with ENOTIMPL.
---
 Kernel/FileSystem/ProcFS.cpp | 5 +++++
 Kernel/FileSystem/ProcFS.h   | 1 +
 2 files changed, 6 insertions(+)

diff --git a/Kernel/FileSystem/ProcFS.cpp b/Kernel/FileSystem/ProcFS.cpp
index ee5cbf149f..5de534fd49 100644
--- a/Kernel/FileSystem/ProcFS.cpp
+++ b/Kernel/FileSystem/ProcFS.cpp
@@ -145,6 +145,11 @@ ErrorOr<void> ProcFSGlobalInode::truncate(u64 size)
     return m_associated_component->truncate(size);
 }
 
+ErrorOr<void> ProcFSGlobalInode::update_timestamps(Optional<time_t>, Optional<time_t>, Optional<time_t>)
+{
+    return {};
+}
+
 InodeMetadata ProcFSGlobalInode::metadata() const
 {
     MutexLocker locker(m_inode_lock);
diff --git a/Kernel/FileSystem/ProcFS.h b/Kernel/FileSystem/ProcFS.h
index b9a878aaad..fe2f18532c 100644
--- a/Kernel/FileSystem/ProcFS.h
+++ b/Kernel/FileSystem/ProcFS.h
@@ -84,6 +84,7 @@ protected:
     virtual ErrorOr<void> traverse_as_directory(Function<ErrorOr<void>(FileSystem::DirectoryEntryView const&)>) const override;
     virtual ErrorOr<NonnullLockRefPtr<Inode>> lookup(StringView) override;
     virtual ErrorOr<void> truncate(u64) override final;
+    virtual ErrorOr<void> update_timestamps(Optional<time_t> atime, Optional<time_t> ctime, Optional<time_t> mtime) override;
 
     NonnullLockRefPtr<ProcFSExposedComponent> m_associated_component;
 };