RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-25 21:05:07 +00:00
Code Issues Activity Actions

LibWeb: Add missing promise rejection in execute_async_script

Browse source
This commit is contained in:
stelar7 2023-06-17 18:17:05 +02:00 • committed by Andrew Kaster
parent b0adf96eff
commit 434d95ef55
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp
View file

@ -358,8 +358,10 @@ ExecuteScriptResultSerialized execute_async_script(Web::Page& page, DeprecatedSt
// NOTE: Prior revisions of this specification did not recognize the return value of the provided script. // NOTE: Prior revisions of this specification did not recognize the return value of the provided script.
// In order to preserve legacy behavior, the return value only influences the command if it is a // In order to preserve legacy behavior, the return value only influences the command if it is a
// "thenable" object or if determining this produces an exception. // "thenable" object or if determining this produces an exception.
if (script_result.is_throw_completion()) if (script_result.is_throw_completion()) {
promise->reject(*script_result.throw_completion().value());
return; return;
}
// 5. If Type(scriptResult.[[Value]]) is not Object, then abort these steps. // 5. If Type(scriptResult.[[Value]]) is not Object, then abort these steps.
if (!script_result.value().is_object()) if (!script_result.value().is_object())
@ -369,8 +371,10 @@ ExecuteScriptResultSerialized execute_async_script(Web::Page& page, DeprecatedSt
auto then = script_result.value().as_object().get(vm.names.then); auto then = script_result.value().as_object().get(vm.names.then);
// 7. If then.[[Type]] is not normal, then reject promise with value then.[[Value]], and abort these steps. // 7. If then.[[Type]] is not normal, then reject promise with value then.[[Value]], and abort these steps.
if (then.is_throw_completion()) if (then.is_throw_completion()) {
promise->reject(*then.throw_completion().value());
return; return;
}
// 8. If IsCallable(then.[[Type]]) is false, then abort these steps. // 8. If IsCallable(then.[[Type]]) is false, then abort these steps.
if (!then.value().is_function()) if (!then.value().is_function())