RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:47:45 +00:00
Code Issues Activity Actions

LibJS: Support move semantics for StringOrSymbol

Browse source 
This allows us to rehash property tables without a bunch of ref count
churn happening.
This commit is contained in:
Andreas Kling 2020-10-15 23:32:54 +02:00
parent 1d96ecf148
commit 4387590e65
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibJS/Runtime/StringOrSymbol.h
View file

@ -84,6 +84,11 @@ public:
as_string_impl().ref(); as_string_impl().ref();
} }
StringOrSymbol(StringOrSymbol&& other)
{
m_ptr = exchange(other.m_ptr, nullptr);
}
ALWAYS_INLINE bool is_valid() const { return m_ptr != nullptr; } ALWAYS_INLINE bool is_valid() const { return m_ptr != nullptr; }
ALWAYS_INLINE bool is_symbol() const { return is_valid() && (bits() & 1ul); } ALWAYS_INLINE bool is_symbol() const { return is_valid() && (bits() & 1ul); }
ALWAYS_INLINE bool is_string() const { return is_valid() && !(bits() & 1ul); } ALWAYS_INLINE bool is_string() const { return is_valid() && !(bits() & 1ul); }
@ -143,6 +148,13 @@ public:
return *this; return *this;
} }
StringOrSymbol& operator=(StringOrSymbol&& other)
{
if (this != &other)
m_ptr = exchange(other.m_ptr, nullptr);
return *this;
}
unsigned hash() const unsigned hash() const
{ {
if (is_string()) if (is_string())