mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 00:27:43 +00:00
LibCore+su+passwd: Don't keep /etc/passwd and /etc/shadow open
Now that we've moved to atomic replacement of these files when altering them, we don't need to keep them open for the lifetime of Core::Account so just simplify this and close them when they are not needed.
This commit is contained in:
parent
77e0598c6d
commit
439f447ba8
4 changed files with 22 additions and 71 deletions
|
@ -74,8 +74,8 @@ int main(int argc, char** argv)
|
|||
uid_t current_uid = getuid();
|
||||
|
||||
auto account_or_error = (username)
|
||||
? Core::Account::from_name(username, Core::Account::OpenPasswdFile::ReadWrite, Core::Account::OpenShadowFile::ReadWrite)
|
||||
: Core::Account::from_uid(current_uid, Core::Account::OpenPasswdFile::ReadWrite, Core::Account::OpenShadowFile::ReadWrite);
|
||||
? Core::Account::from_name(username)
|
||||
: Core::Account::from_uid(current_uid);
|
||||
|
||||
if (account_or_error.is_error()) {
|
||||
warnln("Core::Account::{}: {}", (username) ? "from_name" : "from_uid", account_or_error.error());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue