RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:27:35 +00:00
Code Issues Activity Actions

LibGUI: Set correct value on click with set jump_to_cursor() in Slider

Browse source 
Prior this change, clicking on a slider with set jump_to_cursor() flag
didn't exactly match the knob to the mouse position, and therefore
the slider values were a bit off in the corners.
The calculation used the whole widget size to set new values, which
isn't correct as the track slider has margins on both ends.

I noticed this while seeking in the Sound Player.
This commit is contained in:
Karol Kosek 2021-09-02 22:33:34 +02:00 • committed by Andreas Kling
parent dabbe4ee27
commit 43a800a838
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/Slider.cpp
View file

@ -93,9 +93,9 @@ void Slider::mousedown_event(MouseEvent& event)
if (jump_to_cursor()) {
float normalized_mouse_offset = 0.0f;
if (orientation() == Orientation::Vertical) {
normalized_mouse_offset = static_cast<float>(mouse_offset) / static_cast<float>(height());
normalized_mouse_offset = static_cast<float>(mouse_offset - track_margin()) / static_cast<float>(inner_rect().height());
} else {
normalized_mouse_offset = static_cast<float>(mouse_offset) / static_cast<float>(width());
normalized_mouse_offset = static_cast<float>(mouse_offset - track_margin()) / static_cast<float>(inner_rect().width());
}
int new_value = static_cast<int>(min() + ((max() - min()) * normalized_mouse_offset));