RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:57:44 +00:00
Code Issues Activity Actions

LibCore: Put HTTP debug spam behind FOO_DEBUG macros

Browse source
This commit is contained in:
Andreas Kling 2019-10-15 19:14:11 +02:00
parent 36bb03b6dd
commit 43a9843938
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibCore/CHttpJob.cpp
View file

@ -4,6 +4,8 @@
#include <stdio.h> #include <stdio.h>
#include <unistd.h> #include <unistd.h>
#define CHTTPJOB_DEBUG
CHttpJob::CHttpJob(const CHttpRequest& request) CHttpJob::CHttpJob(const CHttpRequest& request)
: m_request(request) : m_request(request)
{ {
@ -75,7 +77,9 @@ void CHttpJob::on_socket_connected()
} }
auto value = chomped_line.substring(name.length() + 2, chomped_line.length() - name.length() - 2); auto value = chomped_line.substring(name.length() + 2, chomped_line.length() - name.length() - 2);
m_headers.set(name, value); m_headers.set(name, value);
#ifdef CHTTPJOB_DEBUG
dbg() << "CHttpJob: [" << name << "] = '" << value << "'"; dbg() << "CHttpJob: [" << name << "] = '" << value << "'";
#endif
return; return;
} }
ASSERT(m_state == State::InBody); ASSERT(m_state == State::InBody);
@ -120,7 +124,9 @@ void CHttpJob::start()
ASSERT(!m_socket); ASSERT(!m_socket);
m_socket = CTCPSocket::construct(this); m_socket = CTCPSocket::construct(this);
m_socket->on_connected = [this] { m_socket->on_connected = [this] {
#ifdef CHTTPJOB_DEBUG
dbg() << "CHttpJob: on_connected callback"; dbg() << "CHttpJob: on_connected callback";
#endif
on_socket_connected(); on_socket_connected();
}; };
bool success = m_socket->connect(m_request.url().host(), m_request.url().port()); bool success = m_socket->connect(m_request.url().host(), m_request.url().port());

6
Libraries/LibCore/CNetworkJob.cpp
View file

@ -2,6 +2,8 @@
#include <LibCore/CNetworkResponse.h> #include <LibCore/CNetworkResponse.h>
#include <stdio.h> #include <stdio.h>
//#define CNETWORKJOB_DEBUG
CNetworkJob::CNetworkJob() CNetworkJob::CNetworkJob()
{ {
} }
@ -13,7 +15,9 @@ CNetworkJob::~CNetworkJob()
void CNetworkJob::did_finish(NonnullRefPtr<CNetworkResponse>&& response) void CNetworkJob::did_finish(NonnullRefPtr<CNetworkResponse>&& response)
{ {
m_response = move(response); m_response = move(response);
#ifdef CNETWORKJOB_DEBUG
dbg() << *this << " job did_finish!"; dbg() << *this << " job did_finish!";
#endif
ASSERT(on_finish); ASSERT(on_finish);
on_finish(true); on_finish(true);
shutdown(); shutdown();
@ -22,7 +26,9 @@ void CNetworkJob::did_finish(NonnullRefPtr<CNetworkResponse>&& response)
void CNetworkJob::did_fail(Error error) void CNetworkJob::did_fail(Error error)
{ {
m_error = error; m_error = error;
#ifdef CNETWORKJOB_DEBUG
dbgprintf("%s{%p} job did_fail! error: %u (%s)\n", class_name(), this, (unsigned)error, to_string(error)); dbgprintf("%s{%p} job did_fail! error: %u (%s)\n", class_name(), this, (unsigned)error, to_string(error));
#endif
ASSERT(on_finish); ASSERT(on_finish);
on_finish(false); on_finish(false);
shutdown(); shutdown();