RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:17:45 +00:00
Code Issues Activity Actions

test-js: Add a mark_as_garbage method to force GC to collect that object

Browse source 
This should fix the flaky tests of test-js.
It also fixes the tests when running with the -g flag since the values
will not be garbage collected too soon.
This commit is contained in:
davidot 2021-09-07 17:14:05 +02:00 • committed by Linus Groh
parent 3373090993
commit 43b17f27a3
6 changed files with 71 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Tests/builtins/FinalizationRegistry/FinalizationRegistry.prototype.cleanupSome.js
View file

@ -3,11 +3,12 @@ test("length is 0", () => {
});
function registerInDifferentScope(registry) {
registry.register({}, {});
const target = {};
registry.register(target, {});
return target;
}
// Flaky test, investigate and fix :^)
test.skip("basic functionality", () => {
test("basic functionality", () => {
var registry = new FinalizationRegistry(() => {});
var count = 0;
@ -19,7 +20,8 @@ test.skip("basic functionality", () => {
expect(count).toBe(0);
registerInDifferentScope(registry);
const target = registerInDifferentScope(registry);
markAsGarbage("target");
gc();
registry.cleanupSome(increment);