RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:27:35 +00:00
Code Issues Activity Actions

LibWeb: Ignore MessagePort.start() on already-closed port

Browse source 
This matches other browsers, and fixes an assertion found by Domato.
This commit is contained in:
Andreas Kling 2024-03-12 10:53:21 +01:00
parent c11f710628
commit 43d2c920e0
3 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/Messaging/MessagePort-start-after-close.txt Normal file
View file

@ -0,0 +1 @@
PASS (didn't crash)

10
Tests/LibWeb/Text/input/Messaging/MessagePort-start-after-close.html Normal file
View file

@ -0,0 +1,10 @@
<script src="../include.js"></script>
<script>
test(() => {
let channel = new MessageChannel();
let port = channel.port2;
port.close();
port.start();
println("PASS (didn't crash)");
});
</script>

3
Userland/Libraries/LibWeb/HTML/MessagePort.cpp
View file

@ -364,6 +364,9 @@ void MessagePort::post_message_task_steps(SerializedTransferRecord& serialize_wi
// https://html.spec.whatwg.org/multipage/web-messaging.html#dom-messageport-start
void MessagePort::start()
{
if (!is_entangled())
return;
VERIFY(m_socket);
VERIFY(m_fd_passing_socket);