RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Rename Element::computed_style() to resolved_css_values()

Browse source 
This more accurately reflects what's actually being returned.
This commit is contained in:
Andreas Kling 2022-03-15 19:32:17 +01:00
parent 8aa24c45dd
commit 43ef813f3d
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -281,7 +281,7 @@ void Element::recompute_style()
document().invalidate_layout(); document().invalidate_layout();
} }
NonnullRefPtr<CSS::StyleProperties> Element::computed_style() NonnullRefPtr<CSS::StyleProperties> Element::resolved_css_values()
{ {
auto element_computed_style = CSS::ResolvedCSSStyleDeclaration::create(*this); auto element_computed_style = CSS::ResolvedCSSStyleDeclaration::create(*this);
auto properties = CSS::StyleProperties::create(); auto properties = CSS::StyleProperties::create();

2
Userland/Libraries/LibWeb/DOM/Element.h
View file

@ -96,7 +96,7 @@ public:
CSS::StyleProperties const* specified_css_values() const { return m_specified_css_values.ptr(); } CSS::StyleProperties const* specified_css_values() const { return m_specified_css_values.ptr(); }
void set_specified_css_values(RefPtr<CSS::StyleProperties> style) { m_specified_css_values = move(style); } void set_specified_css_values(RefPtr<CSS::StyleProperties> style) { m_specified_css_values = move(style); }
NonnullRefPtr<CSS::StyleProperties> computed_style(); NonnullRefPtr<CSS::StyleProperties> resolved_css_values();
const CSS::CSSStyleDeclaration* inline_style() const { return m_inline_style; } const CSS::CSSStyleDeclaration* inline_style() const { return m_inline_style; }

4
Userland/Services/WebContent/ConnectionFromClient.cpp
View file

@ -353,10 +353,10 @@ Messages::WebContentServer::InspectDomNodeResponse ConnectionFromClient::inspect
} }
String specified_values_json = serialize_json(*element.specified_css_values()); String specified_values_json = serialize_json(*element.specified_css_values());
String computed_values_json = serialize_json(element.computed_style()); String resolved_values_json = serialize_json(element.resolved_css_values());
String custom_properties_json = serialize_custom_properties_json(element); String custom_properties_json = serialize_custom_properties_json(element);
String node_box_sizing_json = serialize_node_box_sizing_json(element.layout_node()); String node_box_sizing_json = serialize_node_box_sizing_json(element.layout_node());
return { true, specified_values_json, computed_values_json, custom_properties_json, node_box_sizing_json }; return { true, specified_values_json, resolved_values_json, custom_properties_json, node_box_sizing_json };
} }
return { false, "", "", "", "" }; return { false, "", "", "", "" };