RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 22:17:42 +00:00
Code Issues Activity Actions

Reduce number of passes in the scheduler by 2.

Browse source
This commit is contained in:
Andreas Kling 2018-11-07 22:24:20 +01:00
parent 39d2fcbbee
commit 440029c9d1
2 changed files with 23 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Process.cpp
View file

@ -857,20 +857,24 @@ void Process::doHouseKeeping()
void Process::for_each(Function<bool(Process&)> callback) void Process::for_each(Function<bool(Process&)> callback)
{ {
ASSERT_INTERRUPTS_DISABLED(); ASSERT_INTERRUPTS_DISABLED();
for (auto* process = g_processes->head(); process; process = process->next()) { for (auto* process = g_processes->head(); process;) {
auto* next_process = process->next();
if (!callback(*process)) if (!callback(*process))
break; break;
process = next_process;
} }
} }
void Process::for_each_in_pgrp(pid_t pgid, Function<bool(Process&)> callback) void Process::for_each_in_pgrp(pid_t pgid, Function<bool(Process&)> callback)
{ {
ASSERT_INTERRUPTS_DISABLED(); ASSERT_INTERRUPTS_DISABLED();
for (auto* process = g_processes->head(); process; process = process->next()) { for (auto* process = g_processes->head(); process;) {
auto* next_process = process->next();
if (process->pgid() == pgid) { if (process->pgid() == pgid) {
if (!callback(*process)) if (!callback(*process))
break; break;
} }
process = next_process;
} }
} }

31
Kernel/Scheduler.cpp
View file

@ -2,6 +2,7 @@
#include "Process.h" #include "Process.h"
#include "system.h" #include "system.h"
//#define LOG_EVERY_CONTEXT_SWITCH
//#define SCHEDULER_DEBUG //#define SCHEDULER_DEBUG
static const dword time_slice = 5; // *10 = 50ms static const dword time_slice = 5; // *10 = 50ms
@ -48,22 +49,20 @@ bool Scheduler::pick_next()
process.unblock(); process.unblock();
return true; return true;
} }
return true;
});
// Forgive dead orphans. // Forgive dead orphans.
// FIXME: Does this really make sense? if (process.state() == Process::Dead) {
Process::for_each_in_state(Process::Dead, [] (auto& process) { if (!Process::from_pid(process.ppid()))
if (!Process::from_pid(process.ppid())) process.set_state(Process::Forgiven);
process.set_state(Process::Forgiven); }
return true;
}); // Release the forgiven.
Process::for_each_in_state(Process::Forgiven, [] (auto& process) {
g_processes->remove(&process);
g_dead_processes->append(&process);
return true;
});
// Clean up forgiven processes.
// FIXME: Do we really need this to be a separate pass over the process list?
Process::for_each_in_state(Process::Forgiven, [] (auto& process) {
g_processes->remove(&process);
g_dead_processes->append(&process);
return true; return true;
}); });
@ -178,6 +177,10 @@ bool Scheduler::context_switch(Process& process)
// mark it as runnable for the next round. // mark it as runnable for the next round.
if (current->state() == Process::Running) if (current->state() == Process::Running)
current->set_state(Process::Runnable); current->set_state(Process::Runnable);
#ifdef LOG_EVERY_CONTEXT_SWITCH
dbgprintf("Scheduler: %s(%u) -> %s(%u)\n", current->name().characters(), current->pid(), process.name().characters(), process.pid());
#endif
} }
current = &process; current = &process;