RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:17:44 +00:00
Code Issues Activity Actions

LibJS: Drop "Record" suffix from all the *Environment record classes

Browse source 
"Records" in the spec are basically C++ classes, so let's drop this
mouthful of a suffix.
This commit is contained in:
Andreas Kling 2021-07-01 12:24:46 +02:00
parent 56d25d7210
commit 44221756ab
40 changed files with 366 additions and 366 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibJS/Runtime/Reference.h
View file

@ -7,7 +7,7 @@
#pragma once
#include <AK/String.h>
#include <LibJS/Runtime/EnvironmentRecord.h>
#include <LibJS/Runtime/Environment.h>
#include <LibJS/Runtime/PropertyName.h>
#include <LibJS/Runtime/Value.h>
@ -18,7 +18,7 @@ public:
enum class BaseType : u8 {
Unresolvable,
Value,
EnvironmentRecord,
Environment,
};
Reference() { }
@ -44,9 +44,9 @@ public:
}
}
Reference(EnvironmentRecord& base, FlyString const& referenced_name, bool strict = false)
: m_base_type(BaseType::EnvironmentRecord)
, m_base_environment_record(&base)
Reference(Environment& base, FlyString const& referenced_name, bool strict = false)
: m_base_type(BaseType::Environment)
, m_base_environment(&base)
, m_name(referenced_name)
, m_strict(strict)
{
@ -58,10 +58,10 @@ public:
return m_base_value;
}
EnvironmentRecord& base_environment() const
Environment& base_environment() const
{
VERIFY(m_base_type == BaseType::EnvironmentRecord);
return *m_base_environment_record;
VERIFY(m_base_type == BaseType::Environment);
return *m_base_environment;
}
PropertyName const& name() const { return m_name; }
@ -75,7 +75,7 @@ public:
{
if (is_unresolvable())
return false;
if (m_base_type == BaseType::EnvironmentRecord)
if (m_base_type == BaseType::Environment)
return false;
if (m_base_value.is_boolean() || m_base_value.is_string() || m_base_value.is_symbol() || m_base_value.is_bigint() || m_base_value.is_number() || m_base_value.is_object())
return true;
@ -109,7 +109,7 @@ private:
BaseType m_base_type { BaseType::Unresolvable };
union {
Value m_base_value {};
EnvironmentRecord* m_base_environment_record;
Environment* m_base_environment;
};
PropertyName m_name;
Value m_this_value;