RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:37:45 +00:00
Code Issues Activity Actions

LibGUI: Make TextEditor substitution more explicit

Browse source 
This patch changes the member for the code point substitution to be an
Optional to remove the implicitness of the zero value.
This commit is contained in:
faxe1008 2022-05-07 16:03:33 +02:00 • committed by Linus Groh
parent 70e2b42b9d
commit 448d6b9acc
2 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibGUI/TextEditor.h
View file

@ -191,8 +191,8 @@ public:
bool should_autocomplete_automatically() const { return m_autocomplete_timer; }
void set_should_autocomplete_automatically(bool);
u32 substitution_code_point() const { return m_substitution_code_point; }
void set_substitution_code_point(u32 code_point);
Optional<u32> const& substitution_code_point() const { return m_substitution_code_point; }
void set_substitution_code_point(Optional<u32> code_point);
bool is_in_drag_select() const { return m_in_drag_select; }
@ -371,8 +371,7 @@ private:
int m_horizontal_content_padding { 3 };
TextRange m_selection;
// NOTE: If non-zero, all glyphs will be substituted with this one.
u32 m_substitution_code_point { 0 };
Optional<u32> m_substitution_code_point;
mutable OwnPtr<Vector<u32>> m_substitution_string_data; // Used to avoid repeated String construction.
RefPtr<Menu> m_context_menu;