RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2026-01-12 23:11:00 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Let WrapperGenerator deal with legacy_null_to_empty_string

Browse source 
This concept is not present in ECMAScript, and it bothers me every time
I see it.
It's only used by WrapperGenerator, and even there only relevant in two
places, so let's fully remove it from LibJS and use a simple ternary
expression instead:

    cpp_name = js_name.is_null() && legacy_null_to_empty_string
        ? String::empty()
        : js_name.to_string(global_object);
This commit is contained in:
Linus Groh 2021-10-11 23:23:52 +01:00
parent 8ea79c05db
commit 44e70d1bc0
3 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Value.h
View file

@ -303,7 +303,7 @@ public:
u64 encoded() const { return m_value.encoded; }
String to_string(GlobalObject&, bool legacy_null_to_empty_string = false) const;
String to_string(GlobalObject&) const;
Utf16String to_utf16_string(GlobalObject&) const;
PrimitiveString* to_primitive_string(GlobalObject&);
Value to_primitive(GlobalObject&, PreferredType preferred_type = PreferredType::Default) const;