RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:57:45 +00:00
Code Issues Activity Actions

Kernel: Fix up various PCI-related function signatures

Browse source 
- Make things const when they don't need to be non-const.
- Don't return AK::String when it's always a string literal anyway.
- Remove excessive get_ prefixes per coding style.
This commit is contained in:
Andreas Kling 2020-04-08 17:09:49 +02:00
parent 15cffc4089
commit 44e889785a
4 changed files with 29 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Kernel/PCI/IOAccess.h
View file

@ -28,29 +28,29 @@
#include <Kernel/PCI/Access.h>
namespace Kernel {
namespace PCI {
class PCI::IOAccess final : public PCI::Access {
class IOAccess final : public PCI::Access {
public:
static void initialize();
virtual void enumerate_all(Function<void(Address, ID)>&) override final;
virtual String get_access_type() override final { return "IO-Access"; };
virtual uint32_t get_segments_count() { return 1; };
virtual void write8_field(Address address, u32, u8) override final;
virtual void write16_field(Address address, u32, u16) override final;
virtual void write32_field(Address address, u32, u32) override final;
protected:
IOAccess();
private:
virtual u8 read8_field(Address address, u32) override final;
virtual u16 read16_field(Address address, u32) override final;
virtual u32 read32_field(Address address, u32) override final;
virtual void enumerate_all(Function<void(Address, ID)>&) override;
virtual const char* access_type() const override { return "IO-Access"; };
virtual uint32_t segment_count() const override { return 1; };
virtual void write8_field(Address address, u32, u8) override final;
virtual void write16_field(Address address, u32, u16) override final;
virtual void write32_field(Address address, u32, u32) override final;
virtual u8 read8_field(Address address, u32) override;
virtual u16 read16_field(Address address, u32) override;
virtual u32 read32_field(Address address, u32) override;
virtual uint8_t get_segment_start_bus(u32) { return 0x0; };
virtual uint8_t get_segment_end_bus(u32) { return 0xFF; };
virtual uint8_t segment_start_bus(u32) const override { return 0x0; }
virtual uint8_t segment_end_bus(u32) const override { return 0xFF; }
};
}
}